-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React grid layout upgrade #3546
base: develop
Are you sure you want to change the base?
Conversation
Removed the window resizing workaround as mentioned in the associated issue. (This merged PR solves the problem.) |
Thanks for taking care of this! One thing I was excited for in this release was the ability to resize from the left and top sides without the weird behavior of it actually shrinking/growing always from the right and bottom sides - we might want to try that out and consider changing the default |
Hi @ghsolomon -- Can you update this to version 1.4.4 and ensure bugs are fixed and everything in order? |
Took a look at this, and v.1.4.4 has that bad bug we were seeing that caused widgets to snap to the top-left corner upon any drag action. Here is a link to the (currently still open) issue: react-grid-layout/react-grid-layout#1990 |
Converting this to DRAFT -- will revisit as soon as we get a new release |
Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.
develop
branch as of last change.breaking-change
label + CHANGELOG if so.If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.