DataViewModel Supports Multiple, Settable SortBy and GroupBy Fields #1715
Conversation
petradish
changed the title
cmp/dataview/DataViewModel.js
Outdated
| return field !== sortBy; | ||
| }).map(field => { | ||
| return { | ||
| colId: field, |
There was a problem hiding this comment.
Not sure if I need colIds here, as field seems to be sufficient identification (at least in the toolbox examples)
|
Petra and I working through this one. |
Signed-off-by: Petra Laohakul <[email protected]>
cmp/grid/Grid.js
Outdated
| @@ -201,6 +201,7 @@ class LocalModel { | |||
| }, | |||
| popupParent: document.querySelector('body'), | |||
| suppressAggFuncInHeader: true, | |||
| suppressMakeColumnVisibleAfterUnGroup: true, | |||
There was a problem hiding this comment.
I thought a bit more about this -- let's just apply this now in DataView's agOptions, where we know we absolutely want this, and that will allow us to move forward with our DataView enhancements.
Think changing Grid default itself needs to be done with a bit more care, testing, and consideration of what we want for our grouping API.
There was a problem hiding this comment.
Great, I moved it to DataView only and its localModel now accepts props and agOptions defined as PT to allow for overriding of the suppressMakeColumnVisibleAfterUngroup prop
…umnVisibleAfterUngroup is set to true Removed property from Grid
+ Clarify Change Message Petra and Lee co-dev
|
Discussed with Petra - she will enhance toolbox with better examples here, but looking forward to getting this in to v30 to more fully round-out the API changes to DataView/ |
Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.
developbranch as of last change.breaking-changelabel + CHANGELOG if so.If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.
This PR addresses #1681
DataViewModel now pushes all store fields as columns but renders only the
sortByfield as visible. This allows for multiple sorters and groupings as well as making them settable through GridModel's trampolined setter methods.