Fix warning for sign-compare (#78)

xfangfang · Apr 25, 2024 · ef7bdfa · ef7bdfa
1 parent 2c76f6b
commit ef7bdfa
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/library/lib/platforms/glfw/glfw_ime.cpp b/library/lib/platforms/glfw/glfw_ime.cpp
@@ -134,7 +134,7 @@ void GLFWImeManager::char_callback(GLFWwindow* window, unsigned int codepoint)
 {
     if (!showIME)
         return;
-    if (cursor < 0 || cursor > textBuffer.size())
+    if (cursor < 0 || cursor > (int)textBuffer.size())
         cursor = textBuffer.size();
     textBuffer.insert(textBuffer.begin() + cursor, (wchar_t)codepoint);
     cursor++;
@@ -204,7 +204,7 @@ void GLFWImeManager::openInputDialog(std::function<void(std::string)> cb, std::s
                     return ;
                 }
                 isEditing = true;
-                if (cursor < 0 || cursor > textBuffer.size()) cursor = textBuffer.size();
+                if (cursor < 0 || cursor > (int)textBuffer.size()) cursor = textBuffer.size();
                 auto left = std::wstring_convert<std::codecvt_utf8<wchar_t>>().to_bytes(textBuffer.substr(0, cursor));
                 auto right = std::wstring_convert<std::codecvt_utf8<wchar_t>>().to_bytes(textBuffer.substr(cursor, textBuffer.size()));
                 dialog->setText(left + preeditTextBuffer + right);
@@ -215,8 +215,8 @@ void GLFWImeManager::openInputDialog(std::function<void(std::string)> cb, std::s
     dialog->getBackspaceEvent()->subscribe([dialog](...)
         {
             if(textBuffer.empty()) return true;
-            if (cursor < 0 || cursor > textBuffer.size()) cursor = textBuffer.size();
-            if (cursor > 0 && cursor <= textBuffer.size()) {
+            if (cursor < 0 || cursor > (int)textBuffer.size()) cursor = textBuffer.size();
+            if (cursor > 0 && cursor <= (int)textBuffer.size()) {
                 textBuffer.erase(cursor - 1, 1);
                 cursor--;
                 dialog->setCursor(cursor);
@@ -239,7 +239,7 @@ void GLFWImeManager::openInputDialog(std::function<void(std::string)> cb, std::s
         {
             if (isEditing) return true;
             if (cursor >= (int)CursorPosition::START) {
-                if (cursor < textBuffer.size()) {
+                if (cursor < (int)textBuffer.size()) {
                     cursor++;
                     dialog->setCursor(cursor);
                 }

diff --git a/library/lib/platforms/glfw/glfw_video.cpp b/library/lib/platforms/glfw/glfw_video.cpp
@@ -292,7 +292,7 @@ GLFWVideoContext::GLFWVideoContext(const std::string& windowTitle, uint32_t wind
     // Set window position
     if (!VideoContext::FULLSCREEN)
     {
-        if (mode->width >= windowWidth && mode->height >= windowHeight)
+        if (mode->width >= (int)windowWidth && mode->height >= (int)windowHeight)
         {
             if (!isnan(windowX) && !isnan(windowY))
             {