Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added skip unknown arguments mode #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lokkie
Copy link

@lokkie lokkie commented Dec 26, 2017

If use cascade application running helps to proceed arguments for Application Runner and Single application

@codecov-io
Copy link

Codecov Report

Merging #38 into master will decrease coverage by 1.02%.
The diff coverage is 28.57%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #38      +/-   ##
============================================
- Coverage     83.66%   82.64%   -1.03%     
  Complexity      136      136              
============================================
  Files            11       11              
  Lines           404      409       +5     
  Branches         81       83       +2     
============================================
  Hits            338      338              
- Misses           31       34       +3     
- Partials         35       37       +2
Impacted Files Coverage Δ Complexity Δ
...main/kotlin/com/xenomachina/argparser/ArgParser.kt 84.8% <28.57%> (-2.14%) 52 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 386f22a...67144b1. Read the comment docs.

@xenomachina
Copy link
Owner

What is the purpose of this change? I don't know what "If use cascade application running helps to proceed arguments for Application Runner and Single application" means.

@SpaceBison
Copy link

Is there a chance that this PR will get merged?

@xenomachina
Copy link
Owner

@SpaceBison I asked a question in January that never got answered: what does "If use cascade application running helps to proceed arguments for Application Runner and Single application" mean?

Aside from that, the code has a couple of "todos" in it that would need to be resolved: "rewrite to correct count detection".

Is this intended to be a solution to issue #40? If so, I'd asked a question there that also never got answered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants