.clang-tidy: Add basic .clang-tidy for identifier naming #1544
+24
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
.clang-tidy
config that covers most identifier naming conventions. Ideally we can offload this component of PR reviews to CI along with formatting in #1510 .Unfortunately it doesn't seem like clang-tidy supports having a separate option for global static variables vs global non-static variables (from what I can tell the
StaticVariable
option only applies to locals), so one limitation of this config is that it will recommend theg_
prefix for global static variables. The alternative is not to enforce a naming convention on the clang-tidy level, but we'd have to continue doing so manually in PR reviews.