fixed issue #107 #119

kambayashia · 2016-09-28T02:08:35Z

Issue Type: Bug

Fixes / Relates To: #107

Changes Included:

change LineItem#to_params

create

twitter-ads v1.0.0 >> line_item = TwitterAds::LineItem.new(account)
=> #<TwitterAds::LineItem:0x70234623841280>
twitter-ads v1.0.0 >> line_item.automatically_select_bid = true
=> true
twitter-ads v1.0.0 >> line_item.save
=> #<TwitterAds::LineItem:0x70234623841280 id="6c5pd">

twitter-ads v1.0.0 >> line_item.automatically_select_bid = false
=> false
twitter-ads v1.0.0 >> line_item.bid_amount_local_micro = 10000
=> 10000
twitter-ads v1.0.0 >> line_item.save
=> #<TwitterAds::LineItem:0x70234633619900 id="6c5pu">

update

twitter-ads v1.0.0 >> line_item.automatically_select_bid = false
=> false
twitter-ads v1.0.0 >> line_item.bid_amount_local_micro = 10000
=> 10000
twitter-ads v1.0.0 >> line_item.save
=> #<TwitterAds::LineItem:0x70134070607520 id="6bvuj">

twitter-ads v1.0.0 >> line_item.bid_amount_local_micro = nil
=> nil
twitter-ads v1.0.0 >> line_item.automatically_select_bid = true
=> true
twitter-ads v1.0.0 >> line_item.save
=> #<TwitterAds::LineItem:0x70256292750640 id="6bvuj">

Check List:

Includes adequate test coverage for changes made.
Includes new or updated documentation.
Includes new or updated usage examples.

For more information on check list items, please see the Contributors Guide.

This reverts commit 15cd8f3.

houndci-bot · 2016-09-28T02:08:40Z

lib/twitter-ads/campaign/line_item.rb

+ params.delete(:bid_type) if params.has_key?(:automatically_select_bid)
+
+ # If set to true, bid_amount_local_micro must be NULL
+ params.store(:bid_amount_local_micro, nil) if params[:automatically_select_bid] && !self.id.nil?


Redundant self detected.
Line is too long. [102/100]

houndci-bot · 2016-09-28T02:08:41Z

lib/twitter-ads/campaign/line_item.rb

+ params = super
+
+ # If automatically_set_bid is set, bid_type must not be set.
+ params.delete(:bid_type) if params.has_key?(:automatically_select_bid)


Use Hash#key? instead of Hash#has_key?.

Scott Martin and others added 6 commits September 28, 2016 11:07

Temporary workaround for xdevplatform#107.

4fab5ef

Revert "Temporary workaround for xdevplatform#107."

03a562d

This reverts commit 15cd8f3.

fix error coming back to gem. related to twitterdev#107

6bb7b20

add bid_amount_local_micro into parameter

a05eece

append bid_amount_local_micro if update campaign

b525e4c

change method

8ac421c

houndci-bot reviewed Sep 28, 2016

View reviewed changes

fix review

3b61b75

kambayashia closed this Nov 7, 2016

kambayashia deleted the hotfix/fix-issue-107 branch December 20, 2016 01:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixed issue #107 #119

fixed issue #107 #119

kambayashia commented Sep 28, 2016

houndci-bot Sep 28, 2016

houndci-bot Sep 28, 2016

fixed issue #107 #119

fixed issue #107 #119

Conversation

kambayashia commented Sep 28, 2016

houndci-bot Sep 28, 2016

Choose a reason for hiding this comment

houndci-bot Sep 28, 2016

Choose a reason for hiding this comment