-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support HTTPS homepage URLs and deprecate the \httplink macro #39
base: master
Are you sure you want to change the base?
Conversation
@@ -1,3 +1,12 @@ | |||
version 2.1.0 (unreleased) | |||
- Deprecate the \httplink macro as it was to unflexible and did only support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍 Fixed.
- Deprecate the \httplink macro as it was too inflexible and did only support links to URLs using the (legacy) HTTP schema and not the new default HTTPS. Use \link. - Change the format of the \homepage macro to support HTTPS homepage URLs. Note that you will need to update your \homepage calls to make it work with the new version. - Switche \social URLs to HTTPS which has long been the default for all the sites supported by \social. Partly mechanical edit: ```Shell git ls-files -z "$(git rev-parse --show-toplevel)" | xargs --null -I '{}' find '{}' -type f -print0 | xargs --null sed --in-place --regexp-extended 's#\\isundefined\{\\@homepage\}#\\isundefined{\\@homepage@url}#g;s#\\httplink\{\\@homepage\}#\\link\[\\@homepage@text\]\{\\@homepage@url\}#g;' ``` Closes: xdanaux#6 Related patchset: xdanaux#40 There should be *no* reason, for people to downgrade to http links just because moderncv only supports legacy URL schemes. Ref: gshakhn/resume@b8c93b9
Maybe not part of this pull request, but how about printing warnings when deprecated macros are used? |
Anything happening to this issue ? It would make tons of sense to deprecate the http:// scheme for the social networks macros in favour of https://. Any reason not to adopt ? |
Note that you will need to update your \homepage calls to make it work with the new version.
Partly mechanical edit:
Closes: #6
Related patchset: #40
There should be no reason for people to downgrade to http links just because moderncv only supports legacy URL schemes. Ref: gshakhn/resume@b8c93b9