2decomp external #251
Merged
2decomp external #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed and activate only TGV test as default
mathrack
reviewed
Feb 4, 2024
There was a problem hiding this comment.
I have a limited understanding of the cmake stuff. Therefore, I can hardly review this PR.
This PR changes the name of the example "Taylor-Green-Vortex" to TGV. However, the turbulent boundary layer is not changed to TBL. This looks a bit inconsistent, I am not sure to understand the underlying motivation.
I think the name for the example xxx should match the corresponding BC-xxx.f90.
Currently, examples and source files have incoherent names for :
- hill
- uniform
- wind-turbine
- TBL
mathrack
reviewed
Feb 4, 2024
mathrack
reviewed
Feb 4, 2024
mathrack
reviewed
Feb 4, 2024
This was
linked to
issues
Feb 5, 2024
mathrack
reviewed
Feb 5, 2024
mathrack
reviewed
Mar 19, 2024
This is more portable/correct Fortran
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working branch to have 2DECOMP&FFT as an external library.