-
-
Notifications
You must be signed in to change notification settings - Fork 241
#40 - Usage inside scrollview issue fixed #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hi @xcarpentier |
|
need this, please approve and merge |
|
Hi, is this still under review? |
sssajjad007
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls merge this
|
@xcarpentier, please, dude, we need this |
|
Please merge! |
|
Hi guys, find attached the patch file :) |
| const setCurrentStep = async (key: string, step?: IStep) => | ||
| new Promise<void>(async (resolve) => { | ||
| if (scrollRef && step) { | ||
| await step.wrapper.measureLayout( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably due to the age of the PR and the differences in react-native since then, but this needs to be step.target, or this will throw with the following error if someone wraps a composite component with a TourGuideZone: ERROR Warning: ref.measureLayout must be called with a ref to a native component.
The patch is not working for me |
|
Please merge it |
@mtebele How do I get the patch to work |
{
|
It seems the start in the patch too does not accept a ref |

Hello Xavier Carpentier, I have fixed scroll issue in plugin, so now we can pass scrollView ref with start function and plugin automatically scroll to the target element