-
Notifications
You must be signed in to change notification settings - Fork 73
Replace raw SQL with Drizzle #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tsg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the translation from SQL to drizzle for all the CRUD stuff (connections, integrations, clusters, etc.) is pretty straightforward and I like how the results look.
I'm unsure about the troubleshooting queries (the ones against targetdb), I kind of like having the raw SQL there so we can try them easier by copy&pasting.
I think the PR doesn't contain yet the migrations folder, right? I'm curious how that will look like.
Signed-off-by: Alexis Rico <[email protected]>
71cc3ab to
0da80a6
Compare
|
@tsg Type safety uncovered that you were mixing |
|
@SferaDev Ah, hmm, I guess it's either:
Do you have a preference? |
|
I have a preference for uuids yeah but don't really mind if we go other way |
Signed-off-by: Alexis Rico <[email protected]>
Signed-off-by: Alexis Rico <[email protected]>
Signed-off-by: Alexis Rico <[email protected]>
No description provided.