Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: DataTree slice generator function #171

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Mar 7, 2023

Description of proposed changes

Very experimental proof of concept to generate subsets out of a multi-resolution DataTree. Do we call the subsets DataBranch 🤔?

Initial implementation is using a standalone function rather than re-using anything from BatchSchema or BatchGenerator.

TODO:

References (some of the complicated for-loops chip generators I've written over the years 🙈):

Fixes #93

Prototype implementation of a tree-like hierarchical data structure for xarray! Repo at https://github.com/xarray-contrib/datatree
Generating subsets of a multi-resolution DataTree! Currently just a handcrafted unit test and a crude for-loop function focusing on the slicing part and not the batching. Will refactor after some discussion.
@weiji14 weiji14 added the enhancement New feature or request label Mar 7, 2023
@weiji14 weiji14 self-assigned this Mar 7, 2023
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #171 (c2f9f01) into main (0f8c619) will increase coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
+ Coverage   96.04%   96.24%   +0.19%     
==========================================
  Files           6        6              
  Lines         329      346      +17     
  Branches       70       74       +4     
==========================================
+ Hits          316      333      +17     
  Misses          8        8              
  Partials        5        5              
Impacted Files Coverage Δ
xbatcher/generators.py 95.16% <100.00%> (+0.48%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

To fix breaking readthedocs build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slicing multiple data layers or band channels with different spatial resolutions
1 participant