Assign new variables by standard names #516
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements
ds.cf.assign(**standard_variables)
. The new method should:**kwargs
or dictionary.Also needed:
I would welcome opinions on the two points below.
1. Decide about the variable short name
I propose this algorithm:
2. When dataset already contains standard name
I find it more difficult to decide what the method should do here.
Dataset.assign
).existing: ignore, override, raise, warn
Note: if we allow multiple variables with the same standard name, the resulting Dataset is technically valid, and
ds.cf
shows several variables associated with one standard name, whileds.cf[standard_name] fails with a
KeyError`.