Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling of cftime bounds #441

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

znichollscr
Copy link

At the moment this just adds a failing test that shows that add_bounds fails if the times are cftimes. I'm not sure what the best solution would be.

@znichollscr
Copy link
Author

@mathause any thoughts on this one? (Calling on a familiar name :))

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #441 (938e566) into main (9383257) will decrease coverage by 49.16%.
The diff coverage is 31.81%.

@@             Coverage Diff             @@
##             main     #441       +/-   ##
===========================================
- Coverage   86.40%   37.24%   -49.16%     
===========================================
  Files          22       21        -1     
  Lines        3994     3936       -58     
  Branches      194      199        +5     
===========================================
- Hits         3451     1466     -1985     
- Misses        491     2271     +1780     
- Partials       52      199      +147     
Flag Coverage Δ
mypy 37.24% <31.81%> (-0.04%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cf_xarray/helpers.py 25.64% <ø> (-40.18%) ⬇️
cf_xarray/tests/test_accessor.py 29.06% <31.81%> (-64.86%) ⬇️

... and 19 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant