Add attribute tracking functionality #253
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple test of pydata/xarray#5668 (cc @keewis)
This just adds the
cell_methods
attribute for reductions and a placeholder for tracking history.There is one top-level function
This returns a partial function that can be provided to
keep_attrs
i.e. it expects the argsattrs, context
. I think we could add things likeprovenance=True
etc. in the future.Right now only the private
_tracker
function satisfies the contract expected bykeep_attrs
. Alternately, we could providetrack_cell_methods
track_history
etc. that satisfy the contract so that users can instead do for fine controlI'm interested in opinions on whether we should do this second approach instead.
cc @huard @aulemahal