-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python bindings #5
Comments
My intention is to put this together as soon as we are happy with yake-rust. Though I could imagine merging this repo into the original project first, then doing the python bindings directly there. Maybe even after a first 1.0.0 release, as a 1.1.0 feature. I have a bunch of code for this already, we just need to work out exactly how we want this to work, and even if it should be in the same project or not. |
I was trying to make it earlier, but the rust interface kept changing and I could not keep up, so I decided to wait until it stabilized. |
Do you think the interface (yake constructor, configs, extract method) will change further? |
Sure it will. Especially if we decide to further optimize the code.
But we can postpone all of those changes or speed them up. I am busy the next 1-2 weeks, so let's do smth that will allow you moving further. We should think about benchmarks, as the crate is a bit useless without them, comparing to py impl. |
In my local code where I wrote python bindings, I had tests that tested
It is not quite benchmarks, but the speed comparison part could of course be an embryo of something like that. The GIL-release is actually a huge deal. And I intend to put make that point very clear wherever we write about the python bindings. |
Personally, I would prefer it if we, in order:
I don't want us to get bogged down just adding features forever so we never get to 1.0.0. Btw, it seems like we do not have any CI? Like running tests and formatting (and clippy?) in github actions? I have little experience with rust projects, but I would expect something like that. |
I used to think the rust code could do miltithreading inside i.e. through rayon, to utilize CPU. But looks like both approaches can coexist. Also, we could ask Kyle either to share ownership or transfer it. If that won't work, then create a separate crate. Asking him to publish new versions is not really practical. |
Yeah maybe. I am not familiar with rayon. I also don't want to go further discussing that now (i.e. before 1.0.0) because I am starting to worry about scope. I agree that maintenance need to be discussed. I am not sure how involved Kyle wants to be, but it seems weird at this point that we would not be able to publish. |
@bunny-therapist described how it works.
The text was updated successfully, but these errors were encountered: