Tracking thread

[xamgore]

No description provided.

[bunny-therapist]

I think, at most, we could add (as @xamgore suggested) the option to pass in pre-tokenized text, but in general, I think we should probably focus on just delivering the fixes we have already made at this point. Further improvements or possible alignment with LIAAD/yake can wait - I just want to make sure we do not lose all the bug fixes and improvements we have made.

[bunny-therapist]

Close #19
Close #15
Close #14
Close #12
Close #11
Close #10
Close #8

[bunny-therapist]

I was hoping that would link the issues and the PR but I guess not.

[xamgore]

Closed as there is just a fork of the current project. https://github.com/xamgore/yake-rust

[bunny-therapist]

I don't understand. Isn't the plan to merge the fork into this project? Why close this PR? Shouldn't it be merged eventually?

[xamgore]

@quesurifn hello! Together with @bunny-therapist we have accomplished 1-1 implementation matching LIAAD/yake, and now have the intention to publish it. Then we could proceed with gradual improvements during the year.

I'd like to discuss the future of this crate.

• Do you want to maintain the crate? If you don't, could you:
  • Transfer the repository to my account with its issues and PRs? Or archive this one.
  • Give publisher rights for yake-rust at crates.io?
• Should we start a new project and claim a fresh crates.io name?

[bunny-therapist]

(Note: we don't quite have 1-1 match yet. We are just very close. :P)

[quesurifn]

@xamgore @bunny-therapist

I'd like to continue to maintain it however, I likely won't be able to be super active for a while due to starting a masters program.

That's said, I'd I'm completely able and willing to give you guys rights. Y'all did a great job tracking down the bugs and fixing the issues from the original version.

Let me know your thoughts.

[quesurifn]

Oh one thing you guys may not be aware of, this package is used with the JS WASM toolchain to release to NPM as well. That's also part of the equation.

[quesurifn]

For now I've invited both of you guys to the github and only @xamgore to Crates. @bunny-therapist I'm getting a username not found error for you on crates.io.

[xamgore]

Is transferring is still an option? I need that to reconfigure the repo, CI/CD, to administer issues, etc. You are the first author and have the full access of course, as well as @bunny-therapist.

I would keep yake-wasm at yours place, as we'll approach it a bit later, and a few PRs would be enough.

starting a masters program

wish you luck 🫠

[bunny-therapist]

Thanks. I don't have a crates.io account, just a pypi account.

[quesurifn]

@xamgore I'm open to it but would like to give it more thought. Maybe we can partner on some of that stuff and if I don't get it done in a reasonable timeframe OR it becomes a burden I'd like to do it?

[xamgore]

Yeah, sure! Thanks 😌

[xamgore]

@bunny-therapist I believe we can continue at this repository, and delete the forks.

[bunny-therapist]

I mean, we still need forks to have somewhere to make PR from?
Or do you mean we should just directly merge to master here? I think I will keep my fork for PR-making purposes, at least for now.

[xamgore]

You may just create a feature branch and push it into this repository. After that you propose a PR from quesurifn:my-duper-branch into quesurifn:master and that's it. You may also push directly to master branch, I will cover your back anyway.