Skip to content
This repository has been archived by the owner on Nov 6, 2024. It is now read-only.

TFM net8.0 and removal of net7.0 was: TFM net8.0 #815

Closed
wants to merge 77 commits into from

Conversation

moljac
Copy link
Member

@moljac moljac commented Nov 1, 2023

net7.0-android hit EOL on May 14, 2024 and thus we will no longer support it in our AndroidX binding packages. Dropping net7.0-android will allow us to support packages that require API-34 like newer versions of Google Material going forward.

Update packages to use net8.0-android instead of net7.0-android.

Note that the "removed" published-namespaces are namespaces that only contained an empty Resources class that is no longer generated.

Samples changes:

  • migrated samples to SDK style projects
  • NuGet Cetntral Package Management
  • collecting of Nugets - minor changes
  • Cake build script - minor changes

Old description:

Does this change any of the generated binding API's?

Probably. Not sure yet. There were some Metadata changes.

Describe your contribution

In May support for Xamarin.Classic (monoandroid12) and net6.0 will be dropped and this is recon PR to see what is ahead of the team.

@moljac moljac added investigating We are currently looking into this do-not-merge in-progress Work is in progress in-test labels Nov 1, 2023
@moljac moljac self-assigned this Nov 1, 2023
@moljac moljac marked this pull request as draft November 1, 2023 06:57
@@ -129,13 +55,5 @@
<ReferenceOutputAssembly>false</ReferenceOutputAssembly>
</ProjectReference>
</ItemGroup>
<Import Project="$(MSBuildExtensionsPath)\Xamarin\Android\Xamarin.Android.CSharp.targets" />
<Import Project="..\Targets\DynamicFeature.targets" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed for the dynamic features to work.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also missing the AssetPacks and Targets folders in the directory above.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jpobst added a commit that referenced this pull request Jun 7, 2024
Break out changes from these PR's to make them more manageable:

- #815
- #874

Remove obsolete Classic samples.
@moljac moljac changed the title [DO NOT MERGE] TFM net8.0 TFM net8.0 and removal of net7.0 was: TFM net8.0 Jun 10, 2024
@moljac moljac marked this pull request as ready for review June 10, 2024 20:12
@moljac moljac requested a review from jpobst June 10, 2024 20:16
@dellis1972
Copy link
Contributor

@moljac

We are still missing the required targets/projects etc for the Asset Pack sample by the looks of things.

@moljac
Copy link
Member Author

moljac commented Jun 13, 2024

@moljac

We are still missing the required targets/projects etc for the Asset Pack sample by the looks of things.

@dellis1972

Just to leave comment here, because it is confusing: that was UI not showing change[s] - targets/projects are not missing.

@jpobst
Copy link
Contributor

jpobst commented Sep 23, 2024

Closing as GPS packages have been moved to https://github.com/xamarin/AndroidX repository and this repository is no longer used.

@jpobst jpobst closed this Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
do-not-merge in-progress Work is in progress in-test investigating We are currently looking into this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants