Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split HostName and IP plus others #5092

Conversation

cybercop23
Copy link
Collaborator

  1. Split Hostname and IP
  2. Make inital sort by IP and make it IP range aware so .100 will be after .99 and not between .1 and .2
  3. Ability to sort on either Hostname or IP column
  4. Last column sorted will be saved and next time used as the initial sort
  5. Added Deselect All for Media
  6. Only show Playlist for FPPs that are in playermode (clean up interface)
  7. Added some more help hints in the column help pop-ups
  8. Initial work for better match of FPPs - created struct with ip, hostname and uuid to be used later for deduping the list

@computergeek1507
Copy link
Member

Added .local to end of a hostname doesn't work on all networks, Dan told me it can cause issues

@cybercop23
Copy link
Collaborator Author

Added .local to end of a hostname doesn't work on all networks, Dan told me it can cause issues

Right.. so it used to be just one link, now there are two. So if hostname.local doesn't work, you can just use the IP one; now that they are separated.

@dkulp
Copy link
Member

dkulp commented Jan 2, 2025

I'm 100% against adding .local to the hostnames. Don't do that.

@cybercop23
Copy link
Collaborator Author

Can we have an option/preference or something else? How else can we do it?
Lots of folks configure and use hostname.local as the ctrl IP and if it works for them great. How can we allow the same in the FPP connect window? Why do we have to keep it "stuck" on IP? There has to be a way to open up hostname also vs just IP

@cybercop23
Copy link
Collaborator Author

What if we first check the controller definitions and if they have any defined with hostname and .local then we know it works for them and we can make the link use that, else if they are all IPs, then just don't make the hostname link-able?

@dkulp
Copy link
Member

dkulp commented Jan 2, 2025

If there network is properly configure, just "http://fpp" works. If there network is not, then they'll need to use IP. I do not use ".local" when going to ANY of my FPP instances.

@dkulp
Copy link
Member

dkulp commented Jan 2, 2025

Fixed up and merged...

@dkulp dkulp closed this Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants