Aggregate labels from merged pull requests #97
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@onk @motemen
This is a revival of #56 originally done by @ohbarye, who kindly allowed me to take over the work. The only change I made is changing the config name from
aggregate_labels
toaggregate-labels
becausegit config
returns an error when the config name contains underscores.Issue
Closes #54
Changes
As described in #54, this change adds a feature to add labels assigned to merged pull requests.
pr-release.aggregate-labels
config (orGIT_RELEASE_PR_AGGREGATE_LABELS
environment variable). It accepts a boolean-ish value, "true" or anything. Only when it is "true",git-release-pr
aggregates labels from merged pull requests.pr-release.labels
is given at the same time, merge them. For example, whenpr-release.labels=foo,bar
and aggregated labels are "baz", labels would be ["foo", "bar", "baz"].Testing
Confirmed
git-pr-release
with this change created a release pull request with a label assigned to a merged pull request.Review Points
aggregate-labels
the best name among other ideas such asreuse-labels
andsummarize-labels
, etc.?aggregate-labels
be given as a command line argument, not environment variable orgit config
, like other boolean values such as--dry-run
and--no-fecth
? (It depends on this gem's command line design.)