fix: fix useClass onInstantiation not running #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wzhudev
reviewed
Jul 6, 2024
bailnl
force-pushed
the
fix/use-class-on-instantiation-not-run
branch
from
f1d606d to
854b72c
Compare
wzhudev
approved these changes
Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复 useClass 时参数 onInstantiation 未能正常运行，原因是 IdleValue 时已经构建实例，导致 IdleValue 内部的 didRun 为 true ，所以需要把 onInstantiation 的执行时机移到 _resolveClassImpl 中