Conversation
Summary of ChangesHello @xerial-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This PR updates protobuf-java to a major new version (4.33.5), which poses a critical risk of binary incompatibility with the existing grpc-java dependency. grpc-java is tightly coupled with protobuf-java, and using a different major version is very likely to cause build or runtime failures. Additionally, some versions in this PR (e.g., protobuf-java: 4.33.5, grpc-java: 1.78.0) are not found in public Maven repositories, which might indicate a configuration issue with Scala Steward. Due to the high risk of breakage, I recommend rejecting this update.
| // For grpc-java | ||
| "io.grpc" % "grpc-protobuf" % GRPC_VERSION, | ||
| "com.google.protobuf" % "protobuf-java" % "3.25.8", | ||
| "com.google.protobuf" % "protobuf-java" % "4.33.5", |
There was a problem hiding this comment.
This major version upgrade of protobuf-java from 3.x to 4.x is incompatible with grpc-java 1.x. The grpc-java project's documentation warns against using different major versions of protobuf-java as it will likely cause binary incompatibilities and failures. To prevent breaking the benchmark module, it's best to revert this change.
"com.google.protobuf" % "protobuf-java" % "3.25.8",
About this PR
📦 Updates com.google.protobuf:protobuf-java from
3.25.8to4.33.5⚠Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conffile.Have a fantastic day writing Scala!
⚙ Adjust future updates
Add this to your
.scala-steward.conffile to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: