Skip to content

Update protobuf-java to 4.33.5#4155

Open
xerial-bot wants to merge 1 commit intomainfrom
update/protobuf-java-4.33.5
Open

Update protobuf-java to 4.33.5#4155
xerial-bot wants to merge 1 commit intomainfrom
update/protobuf-java-4.33.5

Conversation

@xerial-bot
Copy link
Collaborator

About this PR

📦 Updates com.google.protobuf:protobuf-java from 3.25.8 to 4.33.5

Usage

Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.google.protobuf", artifactId = "protobuf-java" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.google.protobuf", artifactId = "protobuf-java" }
}]
labels: library-update

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @xerial-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the protobuf-java dependency to a significantly newer version, moving from 3.25.8 to 4.33.5. This routine maintenance ensures the project benefits from the latest features, performance improvements, and security fixes provided by the Protocol Buffers library, enhancing data serialization capabilities and overall system robustness.

Highlights

  • Dependency Update: The protobuf-java library has been updated from version 3.25.8 to 4.33.5.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR updates protobuf-java to a major new version (4.33.5), which poses a critical risk of binary incompatibility with the existing grpc-java dependency. grpc-java is tightly coupled with protobuf-java, and using a different major version is very likely to cause build or runtime failures. Additionally, some versions in this PR (e.g., protobuf-java: 4.33.5, grpc-java: 1.78.0) are not found in public Maven repositories, which might indicate a configuration issue with Scala Steward. Due to the high risk of breakage, I recommend rejecting this update.

// For grpc-java
"io.grpc" % "grpc-protobuf" % GRPC_VERSION,
"com.google.protobuf" % "protobuf-java" % "3.25.8",
"com.google.protobuf" % "protobuf-java" % "4.33.5",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This major version upgrade of protobuf-java from 3.x to 4.x is incompatible with grpc-java 1.x. The grpc-java project's documentation warns against using different major versions of protobuf-java as it will likely cause binary incompatibilities and failures. To prevent breaking the benchmark module, it's best to revert this change.

        "com.google.protobuf" % "protobuf-java" % "3.25.8",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments