createTranscript Enhancement #90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harsh Gupta <[email protected]>
hargup
force-pushed
the
create_transcript_enhancement
branch
from
ea6a068
to
f10390b
Compare
Signed-off-by: Harsh Gupta <[email protected]>
|
@yeban can you review this PR? |
|
I'm sorry I couldn't get back earlier. Was caught up in other things. I had a quick look - seems good to me. But I will wait to merge till I have had a better look - should be later this week or the next. At this point I can say it would be safe to base further work (more advanced test suite) on this PR (after having rebased it on master). Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Harsh Gupta [email protected]