Add some typechecks

wtetsu · Jun 24, 2019 · 600d61d · 600d61d
1 parent 67f926c
commit 600d61d
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/src/lib/possessive.js b/src/lib/possessive.js
@@ -32,7 +32,7 @@ const normalize = words => {
 const doConvert = (word, conversionRule) => {
   let result = null;
   const w = conversionRule[word];
-  if (w) {
+  if (typeof w === "string") {
     result = w;
   } else {
     const firstCode = word.charCodeAt(0);

diff --git a/src/lib/shortcache.js b/src/lib/shortcache.js
@@ -39,7 +39,7 @@ class ShortCache {
     }
 
     const index = this.dict[key];
-    if (index === undefined) {
+    if (!isFinite(index)) {
       return null;
     }
 

diff --git a/src/lib/spelling.js b/src/lib/spelling.js
@@ -25,7 +25,7 @@ const convert = words => {
 
 const convertWord = word => {
   const w = SPELLING[word];
-  if (w) {
+  if (typeof w === "string") {
     return w;
   }
   return null;

diff --git a/src/lib/transform.js b/src/lib/transform.js
@@ -10,11 +10,11 @@ import text from "./text";
 export default word => {
   const list = new UniqList();
   const v = verbs[word];
-  if (v) {
+  if (typeof v === "string") {
     list.push(v);
   }
   const n = nouns[word];
-  if (n) {
+  if (typeof n === "string") {
     list.push(n);
   }
   const otherForms = text.tryToReplaceTrailingStrings(word, replaceTrailingRules);

diff --git a/src/main/contentgenerator.js b/src/main/contentgenerator.js
@@ -53,7 +53,7 @@ export default class ContentGenerator {
     for (let i = 0; i < words.length; i++) {
       const word = words[i];
       const desc = descriptions[word];
-      if (!desc) {
+      if (typeof desc !== "string") {
         continue;
       }
       data.push({