-
Notifications
You must be signed in to change notification settings - Fork 48
Use published SDK version instead of local replace directives #1067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
renuka-fernando
wants to merge
1
commit into
wso2:main
Choose a base branch
from
renuka-fernando:publised-sdk
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+92
−15
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| name: SDK Integration Test | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| pull_request: | ||
| branches: | ||
| - main | ||
| paths: | ||
| - 'sdk/**' | ||
| - '.github/workflows/sdk-integration-test.yml' | ||
|
|
||
| jobs: | ||
| integration-test: | ||
| runs-on: ubuntu-24.04 | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Go | ||
| uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: '1.25' | ||
|
|
||
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v3 | ||
|
|
||
| - name: Inject local SDK into gateway modules | ||
| run: | | ||
| cd gateway/gateway-runtime/policy-engine | ||
| go mod edit -replace github.com/wso2/api-platform/sdk=../../../sdk | ||
|
|
||
| cd ../../gateway-builder | ||
| go mod edit -replace github.com/wso2/api-platform/sdk=../../sdk | ||
|
|
||
| cd ../gateway-controller | ||
| go mod edit -replace github.com/wso2/api-platform/sdk=../../sdk | ||
|
|
||
| - name: Build gateway images | ||
| run: | | ||
| cd gateway | ||
| make build-local VERSION=test | ||
|
|
||
| - name: Build mock server images | ||
| run: | | ||
| for mock in mock-jwks mock-azure-content-safety mock-aws-bedrock-guardrail mock-embedding-provider mock-analytics-collector; do | ||
| echo "Building $mock..." | ||
| docker build -t ghcr.io/wso2/api-platform/$mock:latest tests/mock-servers/$mock | ||
| done | ||
|
|
||
| - name: Run gateway integration tests | ||
| run: | | ||
| cd gateway | ||
| make test-integration | ||
|
|
||
| - name: Debug on failure - Dump logs | ||
| if: failure() | ||
| run: | | ||
| echo "=== Docker Containers ===" | ||
| docker ps -a | ||
|
|
||
| echo "" | ||
| echo "=== gateway/it/logs Directory Contents ===" | ||
| if [ -d gateway/it/logs ]; then | ||
| if [ "$(ls -A gateway/it/logs)" ]; then | ||
| for f in gateway/it/logs/*; do | ||
| echo "" | ||
| echo "--- Contents of $f ---" | ||
| cat "$f" | ||
| done | ||
| else | ||
| echo "No log files found in gateway/it/logs." | ||
| fi | ||
| else | ||
| echo "Directory gateway/it/logs does not exist." | ||
| fi | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing
go mod tidyafter injecting replace directives.After
go mod edit -replace, thego.sumfiles won't reflect the local SDK's transitive dependencies. If the local SDK differs from v0.3.9 in its dependency graph, subsequentgo buildorgo testmay fail or fetch unexpected versions. Rungo mod tidyin each module after editing.Also, the chained
cdnavigation is fragile — consider using absolute paths from$GITHUB_WORKSPACEfor clarity.Proposed fix
- name: Inject local SDK into gateway modules run: | - cd gateway/gateway-runtime/policy-engine - go mod edit -replace github.com/wso2/api-platform/sdk=../../../sdk + cd $GITHUB_WORKSPACE/gateway/gateway-runtime/policy-engine + go mod edit -replace github.com/wso2/api-platform/sdk=../../../sdk + go mod tidy - cd ../../gateway-builder - go mod edit -replace github.com/wso2/api-platform/sdk=../../sdk + cd $GITHUB_WORKSPACE/gateway/gateway-builder + go mod edit -replace github.com/wso2/api-platform/sdk=../../sdk + go mod tidy - cd ../gateway-controller - go mod edit -replace github.com/wso2/api-platform/sdk=../../sdk + cd $GITHUB_WORKSPACE/gateway/gateway-controller + go mod edit -replace github.com/wso2/api-platform/sdk=../../sdk + go mod tidy🤖 Prompt for AI Agents