Fixed "Upgrading to 1.2.0+ disables admin UI ([#32](#32))" bug caused…

… by LibXML rendering self closing `iframe`.
wrav · Feb 5, 2020 · d8ca2c8 · d8ca2c8
1 parent c3fe79d
commit d8ca2c8
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,10 @@
 # oEmbed Changelog
 
+## 1.2.3 - 2020-02-05
+
+### Fixed
+- Fixed "Upgrading to 1.2.0+ disables admin UI ([#32](https://github.com/wrav/oembed/issues/32))" bug caused by LibXML rendering self closing `iframe`.
+
 ## 1.2.2 - 2020-01-30
 
 ### Updated

diff --git a/composer.json b/composer.json
@@ -2,7 +2,7 @@
     "name": "wrav/oembed",
     "description": "A simple plugin to extract media information from websites, like youtube videos, twitter statuses or blog articles.",
     "type": "craft-plugin",
-    "version": "1.2.2",
+    "version": "1.2.3",
     "keywords": [
         "craft",
         "cms",

diff --git a/src/services/OembedService.php b/src/services/OembedService.php
@@ -100,7 +100,7 @@ public function __call(string $name , array $arguments )
                 }
 
                 $iframe->setAttribute('src', $src);
-                $media->code = $dom->saveXML($iframe);
+                $media->code = $dom->saveXML($iframe, LIBXML_NOEMPTYTAG);
             } catch (\Exception $exception) {
                 Craft::info($exception->getMessage(), 'oembed');
             }