fix!: typos in API naming #2212
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So, since the function name is already incorrect, we cannot change it because it will break the current users. In this case, we have to leave it as it is until we release a more comprehensive breaking change. |
|
what if I prepare a deprecation instead so that no one else starts using the methods/enums with typos and uses the correct name?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stopRecoring->stopRecordingGroupNotificationType.Inivite->GroupNotificationType.InviteThis change might make a lot of code incompatible, so maybe it is better to save this for the next major release?
Before merging; I think I found one more potential typo:
https://github.com/gekkedev/wppconnect/blob/76baaca6fcb824b26f94a12339c3fda0ef7d5129/src/api/layers/sender.layer.ts#L145
Should be
"error"in my opinion, but: Is this key from the platform or is it created by WPPC?