-
-
Notifications
You must be signed in to change notification settings - Fork 1
Implement Search #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Implement Search #50
Conversation
|
Okay search fields have been moved from a revealer to a popover The search now works semi-ok, and there is a smooth scrolling to go to the found term the big blocker i now have is that TextIter is not supposed to crash if it rewinds/search too far/doesnt find anything. It is supposed to return a False. |
|
Okay -At current, the search always starts from the end. I will get around to fix this but havent found yet -because of TextIter search methods apparently crashing instead of returning a boolean, search relies on a very dirty workaround to ensure search without crash. If someone opens huge text files they will notice (the method scans at worst the whole buffer three times for one term search) |
|
Okay @wpkelso Could you please try it out and let me know what you think, if that is ok with you? Because of a bug that forces me to do an ugly workaround to avoid a crash, it is not "optimal", but a search through 10 times the whole Martin Luther King speech has no sign of slowing the UI down. |
fix #39
requires #52
The search is very crashy, though it correctly finds a few words... if you copy paste them.
I am still working on this. But the UI part fully works so you can already get an idea
If you plan a toolbar, i can move the content of the revealer into a neat little popover though