Fix deprecated statement, simplify code #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Deprecated statement See threads about deprecated code here: https://wordpress.org/support/topic/deprecated-feature/ https://wordpress.org/support/topic/update-pluggin-deprecated-coce/ ``` Deprecated: Unparenthesized `a ? b : c ? d : e` is deprecated. Use either `(a ? b : c) ? d : e` or `a ? b : (c ? d : e)` in […]/plugins/admin-bar-user-switching/functions/abus-core-functions.php on line 14 ``` ### Simplify code The code WordPress uses in `WP_List_Table::pagination()` is: ``` $current_url = set_url_scheme( 'http://' . $_SERVER['HTTP_HOST'] . $_SERVER['REQUEST_URI'] ); ``` I'd prefer to just use `add_query_arg( array() );` but don't know the back-story of why the code currently is how it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated statement
See threads about deprecated code here:
https://wordpress.org/support/topic/deprecated-feature/
https://wordpress.org/support/topic/update-pluggin-deprecated-coce/
Simplify code
The code WordPress uses in
WP_List_Table::pagination()is:I'd prefer to just use
add_query_arg( array() );but don't know the back-story of why the code currently is how it is.