Latest node version and few small fixes #109
Conversation
Note: Package node-ffi is maintain, but owner is missing, no one can`t publish fresh version to npm
Update readme add information related with ubuntu and debian OS
.gitignore
Outdated
| @@ -3,3 +3,4 @@ | |||
| /node_modules/ | |||
| /spec/**/*.js | |||
| *.dll | |||
| .idea | |||
There was a problem hiding this comment.
This is an editor specific ignore and should be in your global configuration (https://help.github.com/articles/ignoring-files/#create-a-global-gitignore and https://help.github.com/articles/ignoring-files/#explicit-repository-excludes)
| - '7' | ||
| - '8' | ||
| - '9' | ||
| - '10' |
README.md
Outdated
| @@ -81,6 +81,16 @@ to `libblp.dll` and ensure it ends up on the load PATH. | |||
| By default, node-gyp compiles ffi for x64 so make sure `libblp.dll` | |||
| matches this architecture. | |||
|
|
|||
| #### Ubuntu, Debian | |||
| ```shell | |||
There was a problem hiding this comment.
Could you add a newline between the heading and the code snippet?
src/lib/mpq/chain.js
Outdated
| @@ -27,7 +27,7 @@ class MPQChain { | |||
| path.join(dataDir, mpq) | |||
| )); | |||
|
|
|||
| const archives = glob.sync(patterns); | |||
| const archives = glob.sync(patterns, {nocase: true}); | |||
There was a problem hiding this comment.
For which scenario is this a requirement? Are MPQs shipped with variants in casing?
There was a problem hiding this comment.
Make sure to run npm run lint to comply with the linting configuration for this project. In this case, we require spacing within object literals.
There was a problem hiding this comment.
Soo, for example from torrent sometime I get with random case :) Mostly it for custom clients, I help for some private server project, which has big count of client changes (races, quests, spells, models and etc) and you database API is helpful for it (but not working properly at this moment, custom races not properly show and quests eat CPU and memory but nothing shown) and yes, all mpq`s in lower case
There was a problem hiding this comment.
Sounds good to me. If you could add the spacing, that'd be great 👍
As for custom races not properly showing and quests consuming CPU / memory, please open separate issues. There's likely things that can be done there.
There was a problem hiding this comment.
I will make changes for you review in 15-20 hours, have some other work.
Fix code style (lint) Remove unneeded line from .gitignore Regenerate package json using npm 5.10
|
Looks good, thanks! 👍 |
Add support for node 9 & 10
Note: Package node-ffi is maintain, but owner is missing, no one can`tpublish fresh version to npm, there is no releases since 2016.
node-ffi/node-ffi#465 (comment)
Updated readme for linux build
Fixed problems on case sensetive systems with chain js (face with it when test your DB api) I tested on my custom client, where patches named randomly