node: Extend flow cancel by configuring allow-list of chain ID pairs ("pipes") #4229
+433
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsaigle
changed the title
johnsaigle
force-pushed
the
flow-cancel-pipes
branch
from
4303203 to
35e937b
Compare
djb15
reviewed
Jan 27, 2025
johnsaigle
requested review from
mdulin2,
pleasew8t,
bruce-riley,
evan-gray and
panoel
as code owners
johnsaigle
force-pushed
the
flow-cancel-pipes
branch
from
54d16d7 to
2c1ba16
Compare
djb15
reviewed
Feb 28, 2025
node/pkg/governor/governor_test.go
Outdated
There was a problem hiding this comment.
Could you add a test for the flow_cancel_pipes.go file? Would be good to validate the mainnet list of pipes before deployment ideally, even though we have the runtime checks
There was a problem hiding this comment.
Thanks for adding! I was also thinking that it would be good to check every entry to make sure it's a valid pipe and that there are no duplicate pipes
- Add a concept of "pipes" which consist of a pair of chains - Add field in the Governer that enables flow cancel only for "pipes" which are explicitly enabled - Set the Eth-Sui pipe as the only flow cancel-enabled pair. Sui is the only chain with frequent governor congestion so it is the only one that really needs the Flow Cancel capabilities. Ethereum is the main chain that Sui is interacting with in terms of volume moving in and out of Sui. - Refactor calling sites for flow cancel transfer functions so that all checks are done in one place. (Should help prevent bugs where only one calling site is updated.)
- Add unit tests to ensure that the flow cancel feature works iff valid pipes are configured - Adds unit tests for the pipe type (validity, equality between two pipes) - Modifies pipe.equals() to always return false for invalid pipes
johnsaigle
force-pushed
the
flow-cancel-pipes
branch
from
037c0ad to
a24d86d
Compare
djb15
reviewed
Feb 28, 2025
node/pkg/governor/governor.go
Outdated
| gov.logger.Warn("Error when attempting to add a flow cancel transfer", | ||
| zap.Error(err), | ||
| ) | ||
| return false, err |
There was a problem hiding this comment.
Same question for this early return, do we want this? And should the newTransferFromDbTransfer come before the StoreTransfer call?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.