-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
evm: Add source chain topic to TransferRedeemed
and MessageAttestedTo
events
#566
base: main
Are you sure you want to change the base?
Conversation
48060cd
to
ac18169
Compare
ac18169
to
a95edc8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
High level Q: what's the motivation for this change? Why do we need the source chain id in these events?
Main context behind the change is to address this issue: #504. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there the intention for integrators to potentially upgrade existing deployments?
I'd love to see a couple of tests that involve having queued transfers (both inbound and outbound) with a previous deployment, before upgrading to this functionality and trying to release the queued transfers. You may have to do this by manually writing into a slot with the old struct format to fake a queued transfer before an upgrade; that way your test doesn't have to deal with upgrades directly.
For reference, this is why I suggested you move the the new fields to the end of the structs as otherwise the reads of existing queued transfers will be borked; moving to the end of the struct should work but a test to verify would be great.
This PR adds:
sourceChain
topic toMessageAttestedTo
andTransferRedeemed
eventssourceChain