Skip to content

feat: introduce verify factor endpoint#186

Merged
paolodamico merged 3 commits intomainfrom
verify-factor
Feb 17, 2026
Merged

feat: introduce verify factor endpoint#186
paolodamico merged 3 commits intomainfrom
verify-factor

Conversation

@paolodamico
Copy link
Contributor

@paolodamico paolodamico commented Feb 17, 2026

Introduces a /v1/verify-factor endpoint (and related challenge endpoints) which lets a user authenticate with a main factor and validate only the authorization of the Main factor. This is useful in order for the client to verify a particular factor is still properly authorized for a backup (similar to /v1/retrieve-from-challenge) but without retrieving the full backup to avoid the additional overhead everywhere.

@tomislavhoman @TinJukic-Flabbergast


Note

Medium Risk
Adds new authentication endpoints and a new challenge context, so mistakes could affect factor verification or allow misuse if context/scope checks regress; coverage is strong via integration tests and Attestation Gateway enforcement.

Overview
Adds a new "verify factor" flow that lets clients authenticate a main factor and receive only the associated backupId, avoiding full backup retrieval.

Introduces ChallengeContext::VerifyFactor plus three new routes: /v1/verify-factor/challenge/passkey, /v1/verify-factor/challenge/keypair, and /v1/verify-factor (protected by Attestation Gateway). Adds integration tests covering passkey and EC keypair success paths and key failures (invalid token/context, nonexistent or sync factor, missing/invalid attestation token) and asserting no backup payload is returned.

Written by Cursor Bugbot for commit 4ea3723. This will update automatically on new commits. Configure here.

@paolodamico
Copy link
Contributor Author

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Keep them coming!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Contributor

@aurel-fr aurel-fr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, test coverage is extensive

@paolodamico paolodamico merged commit 2fec2a5 into main Feb 17, 2026
12 checks passed
@paolodamico paolodamico deleted the verify-factor branch February 17, 2026 12:30
@github-actions github-actions bot mentioned this pull request Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments