feat: introduce verify factor endpoint#186
Merged
paolodamico merged 3 commits intomainfrom Feb 17, 2026
Merged
Conversation
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
aurel-fr
approved these changes
Feb 17, 2026
Contributor
aurel-fr
left a comment
There was a problem hiding this comment.
lgtm, test coverage is extensive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a
/v1/verify-factorendpoint (and related challenge endpoints) which lets a user authenticate with a main factor and validate only the authorization of the Main factor. This is useful in order for the client to verify a particular factor is still properly authorized for a backup (similar to/v1/retrieve-from-challenge) but without retrieving the full backup to avoid the additional overhead everywhere.@tomislavhoman @TinJukic-Flabbergast
Note
Medium Risk
Adds new authentication endpoints and a new challenge context, so mistakes could affect factor verification or allow misuse if context/scope checks regress; coverage is strong via integration tests and Attestation Gateway enforcement.
Overview
Adds a new "verify factor" flow that lets clients authenticate a main factor and receive only the associated
backupId, avoiding full backup retrieval.Introduces
ChallengeContext::VerifyFactorplus three new routes:/v1/verify-factor/challenge/passkey,/v1/verify-factor/challenge/keypair, and/v1/verify-factor(protected by Attestation Gateway). Adds integration tests covering passkey and EC keypair success paths and key failures (invalid token/context, nonexistent or sync factor, missing/invalid attestation token) and asserting no backup payload is returned.Written by Cursor Bugbot for commit 4ea3723. This will update automatically on new commits. Configure here.