Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

httr2 #70

Open
wants to merge 14 commits into
base: DEV
Choose a base branch
from
Open

httr2 #70

wants to merge 14 commits into from

Conversation

tonyfujs
Copy link
Member

@tonyfujs tonyfujs commented Sep 5, 2023

This is a re-write of pipr using httr2 under the hood instead of httr. The high-level functions accessible to the end-users have not changed, but the use of httr2 brings some nice new features:

  • Automatic local caching of API responses using the PIP API response headers to control the caching behavior
  • Automatic handling of retry when hitting the PIP API rate-limiting threshold (currently set to 5 requests per minutes in QA for testing purposes)
  • Improved translations of HTTP errors into R error messages
  • Two new helper functions have been added to get information about, and delete the local cache

@tonyfujs
Copy link
Member Author

tonyfujs commented Sep 5, 2023

Hello @shahronak47 I think this is ready for review for merging into DEV. Let me know if you have any question. Thanks!

cc @randrescastaneda

Copy link
Contributor

@shahronak47 shahronak47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tonyfujs , there are some warnings in R CMD CHECK regarding documentation.

Argument items with no description in Rd object 'build_request':
‘...’

Argument items with no description in Rd object 'parse_error_body':
‘resp’

@shahronak47
Copy link
Contributor

Also, I noticed some examples no longer work. I have created an issue here #71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants