chore: use named RegEx group

worksome · Sep 9, 2024 · f107c33 · f107c33
1 parent b839acb
commit f107c33
Showing 1 changed file with 11 additions and 9 deletions.
diff --git a/src/Plugin.php b/src/Plugin.php
@@ -73,7 +73,7 @@ private function handleEnablingCoverage(array &$arguments): void
     private function handleMinCoverage(array &$arguments): void
     {
         $coverageMinRegex = /** @lang RegExp */
-            '/^--gql-min=(\d+)$/';
+            '/^--gql-min=(?<value>\d+)$/';
         $min = preg_grep($coverageMinRegex, $arguments);
 
         if ($min === false || count($min) === 0) {
@@ -84,17 +84,17 @@ private function handleMinCoverage(array &$arguments): void
 
         preg_match($coverageMinRegex, array_pop($min), $matches);
 
-        if (! isset($matches[1])) {
+        if (! isset($matches['value'])) {
             return;
         }
 
-        $this->coverageMin = (int) $matches[1];
+        $this->coverageMin = (int) $matches['value'];
     }
 
     private function handleSchemaCommand(array &$arguments): void
     {
         $schemaCommandRegex = /** @lang RegExp */
-            '/^--schema-command=(.*)$/';
+            '/^--schema-command=(?<value>.*)$/';
         $command = preg_grep($schemaCommandRegex, $arguments);
 
         if ($command === false || count($command) === 0) {
@@ -105,17 +105,17 @@ private function handleSchemaCommand(array &$arguments): void
 
         preg_match($schemaCommandRegex, array_pop($command), $matches);
 
-        if (! isset($matches[1])) {
+        if (! isset($matches['value'])) {
             return;
         }
 
-        $this->schemaCommand = $matches[1];
+        $this->schemaCommand = $matches['value'];
     }
 
     private function handleMaxUntestedFields(array &$arguments): void
     {
         $maxUntestedFieldsRegex = /** @lang RegExp */
-            '/^--gql-untested-count=(.*)$/';
+            '/^--gql-untested-count=(?<value>.*)$/';
         $command = preg_grep($maxUntestedFieldsRegex, $arguments);
 
         if ($command === false || count($command) === 0) {
@@ -126,11 +126,13 @@ private function handleMaxUntestedFields(array &$arguments): void
 
         preg_match($maxUntestedFieldsRegex, array_pop($command), $matches);
 
-        if (! isset($matches[1])) {
+        if (! isset($matches['value'])) {
             return;
         }
 
-        $this->maxUntestedFieldsCount = is_numeric($matches[1]) ? (int) $matches[1] : $this->maxUntestedFieldsCount;
+        $this->maxUntestedFieldsCount = is_numeric($matches['value'])
+            ? (int) $matches['value']
+            : $this->maxUntestedFieldsCount;
     }
 
     public function addOutput(int $exitCode): int