Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dsync.deactivated event #1086

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kendallstrautman
Copy link
Contributor

@kendallstrautman kendallstrautman commented Jul 24, 2024

Description

This event is never emitted so we are officially deprecating.

Documentation

Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.

[ ] Yes

If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.

No this was removed from the docs in this PR and removed from the dashboard in this PR.

@kendallstrautman kendallstrautman requested a review from a team as a code owner July 24, 2024 21:11
@kendallstrautman kendallstrautman marked this pull request as draft July 24, 2024 21:30
@kendallstrautman
Copy link
Contributor Author

kendallstrautman commented Jul 24, 2024

We may just fully delete this since its been years since the event has been emitting. Going to check in with teams listening for this event first though.

Confirmed, we are going to remove it.

@kendallstrautman kendallstrautman changed the title Deprecate dsync.deactivated event Remove dsync.deactivated event Jul 25, 2024
@kendallstrautman kendallstrautman marked this pull request as ready for review July 25, 2024 17:53
@mattgd mattgd added the breaking change Contains a breaking change label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Contains a breaking change
Development

Successfully merging this pull request may close these issues.

2 participants