Add docker build to goreleaser #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkajla12
reviewed
Aug 7, 2024
Dockerfile
Outdated
| @@ -0,0 +1,3 @@ | |||
| FROM scratch | |||
| COPY ./bin/workos /bin/workos | |||
| ENTRYPOINT ["/bin/workos"] | |||
There was a problem hiding this comment.
Can you add a new line to the end of this file?
kkajla12
reviewed
Aug 7, 2024
| @@ -61,3 +61,10 @@ brews: | |||
| commit_author: | |||
| name: WorkOS | |||
| email: [email protected] | |||
| dockers: | |||
| - ids: | |||
| - linux | |||
There was a problem hiding this comment.
I wonder if it's worth building/publishing images for x86-64 and ARM? (For Windows and ARM machines)
There was a problem hiding this comment.
not sure, but if the aim is to provide support for ci pipelines, it seems that linux should be enough.
There was a problem hiding this comment.
Ok, in that case, we might need to update the tags in the ECR public gallery because it shows Windows and ARM64 as supported platforms
kkajla12
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add docker image build to goreleaser. Also, update github action workflow to login to the ecr public registry. This will require aws credentials to be setup in the repo as actions secrets.