fix: allow signOut to work outside middleware coverage #296
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue #261 by enabling
signOut()
to function when called from routes not covered by the AuthKit middleware.Problem
Previously, when users implemented custom middleware (as documented), the
signOut()
function would fail because it relied onwithAuth()
which requires the AuthKit middleware to be running. This meant users could only clear the local session cookie but couldn't properly log out from the WorkOS domain.Solution
withAuth()
throwsChanges
signOut()
insrc/auth.ts
to catch errors fromwithAuth()
and attempt recoverygetSessionFromCookie()
fromsrc/session.ts
for internal use (not publicly exported)Testing
Added tests to verify:
Fixes #261