Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xcode 13 support + iOS 15 fixes #17415

Merged
merged 39 commits into from
Nov 10, 2021
Merged

Xcode 13 support + iOS 15 fixes #17415

merged 39 commits into from
Nov 10, 2021

Conversation

leandroalonso
Copy link
Contributor

Adds support to Xcode 13 (including CI) and fixes issues for iOS 15 + Xcode 13 combo.

Included issues:

To test

  1. Run the app
  2. Make sure the app has the same look 'n feel
  3. Make sure CI is 🟢

Regression Notes

  1. Potential unintended areas of impact
    The whole project

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual test

  3. What automated tests I added (or what prevented me from doing so)
    n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

leandroalonso and others added 30 commits September 27, 2021 14:31
@leandroalonso
FIx: tab bar background on iOS 15
67a3fac
@leandroalonso
Add: sets iOS 15 new sectionHeaderTopPadding to zero
b54678a
@leandroalonso
Merge pull request #17225 from wordpress-mobile/issue/17172_fix_tab_b…
b8df857 
…ar_background

iOS 15: fix tab bar background
@leandroalonso
Merge pull request #17227 from wordpress-mobile/issue/ios_15_table_vi…
4d5f673 
…ew_header_top_padding

iOS 15: fix the top padding on Table View's header
@leandroalonso
Change: Xcode image from 12 to 13
33746be
@leandroalonso
Fix: image name
bdcec49
@mokagio
Bump CircleCI Xcode image version to 13.0.0
49b0ed0
@mokagio
Bump .xcversion value from 12.5 to 13.0
6e08748
@mokagio
Use latest Ruby version in CircleCI, 2.7.4
136f4ee 
Prior to this change, we were using `2.6.6` but that version is no
longer available in the Xcode 13 image.

See error message here:
https://app.circleci.com/pipelines/github/wordpress-mobile/WordPress-iOS/24560/workflows/74788ee1-f42e-4876-96c6-4e75e74016d4/jobs/57379
Remove MockContext from unit tests
52ebbd0
Rearrange project files
432ed7c
Replace the use of MockContext with TestContextManager.mainContext in…
5b15ec1 
… unit tests, to address build issues on Xcode 13
@mokagio
Update Simulator device and iOS version to use in CircleCI
202c76a
@mokagio
Update Fastlane from 2.184.1 to 2.195.0
b5a75cc 
I did this to see if it solved the issues we are experiencing with Xcode
13 testing, but that didn't help.
@ScoutHarris
Merge branch 'develop' into issue/xcode_13
4de57a1
@ScoutHarris
Fix sheet being fullscreen in iOS15.
56f8c73
@mokagio
Use new Automattic Xcode 13 image in Buildkite
a99d8c6
@mokagio
Run tests on iOS 15 in Buildkite
b5418e5
@ScoutHarris
Merge pull request #17379 from wordpress-mobile/fix/17378-user_profil…
4a3b43a 
…e_sheet_ios15

iOS 15: Fix user profile sheet being shown fullscreen
@leandroalonso
fastlane: filter tests to prevent test crashes
e337922
@jkmassel
Fix Ruby Issue
fc376fd
@ScoutHarris
Merge branch 'develop' into issue/xcode_13
21f4d52
@ScoutHarris
Merge branch 'develop' into issue/xcode_13
0e2ed80
@oguzkocer @leandroalonso
Update translations
54d07bd
@oguzkocer @leandroalonso
Update metadata translations
dc57a07
@oguzkocer @leandroalonso
Update Jetpack metadata translations
3fffe76
@oguzkocer @leandroalonso
Bump version number
db41dd5
@oguzkocer @leandroalonso
Update translations
73737bd
@oguzkocer @leandroalonso
Bump version number
1307f9b
@oguzkocer @leandroalonso
Remove subtitle.txt files from jetpack_metadata
a7ecaed
@leandroalonso leandroalonso added this to the 18.7 milestone Nov 3, 2021
@leandroalonso leandroalonso self-assigned this Nov 3, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 3, 2021 •
edited
Loading

You can trigger an installable build for these changes by visiting CircleCI here.

@leandroalonso leandroalonso changed the title Xcode 13 + iOS 15 support Xcode 13 support + iOS 15 fixes Nov 3, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 3, 2021 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

jkmassel
jkmassel approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@jkmassel jkmassel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the code side of things

@mokagio
Read Ruby version for chruby from .ruby-version in CircleCI
f963937 
This ensures there is a single source of truth fro the Ruby version
across:

- Local tooling
- CircleCI
- Buildkite
@mokagio
Bump Ruby version to latest 2.x stable: 2.7.4
3fdcc22
mokagio
mokagio reviewed Nov 4, 2021
View reviewed changes
Copy link
Contributor

@mokagio mokagio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkmassel @leandroalonso LGTM, too. I opened a PR against this branch to ensure we use the same Ruby version across the board: #17418. I think we should wait till that one is merged in here before merging into develop.

@AliSoftware
Merge pull request #17418 from wordpress-mobile/ruby-version-source-o…
5aa63b3 
…f-truth

Read Ruby version for chruby from .ruby-version in CircleCI
AliSoftware
AliSoftware approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've now merged #17418, so this should now be ready to merge.

I left a comment suggestion to ensure we won't forget to remove the "temporary fixes until Xcode 13.1" next time we update the IMAGE_ID (because I feel we'd otherwise miss it); take it or leave it 🙃

.buildkite/commands/build-for-testing.sh Outdated Show resolved Hide resolved
@mokagio
Copy link
Contributor

mokagio commented Nov 5, 2021

We sent out an internal communication (ref. pbArwn-38I) announcing the official Xcode 13 support and will merge this PR on November 9, just to give folks a couple of days to read the announcement and download Xcode 13 if they haven't done so yet.

@mokagio mokagio merged commit 0f03ee0 into develop Nov 10, 2021
@mokagio mokagio deleted the issue/xcode_13 branch November 10, 2021 02:51
@mokagio mokagio mentioned this pull request Nov 11, 2021
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mokagio mokagio mokagio left review comments

@jkmassel jkmassel jkmassel approved these changes

@AliSoftware AliSoftware AliSoftware approved these changes

Assignees

@leandroalonso leandroalonso

Labels
None yet
Projects
None yet
Milestone
18.7
Development

Successfully merging this pull request may close these issues.
6 participants
@leandroalonso @mokagio @AliSoftware @jkmassel @ScoutHarris @oguzkocer