Code Review

README.md

@@ -1 +1,17 @@
-# java-calculator-precourse
+# java-calculator-precourse
+
+구현 할 기능 목록
+1. 문자열을 입력받는 기능
+2. 문자열을 구분자를 기준으로 분리하는 기능
+3. 커스텀 구분자를 지정하는 기능
+4. 잘못된 값을 입력할 경우 예외처리하는 기능
+5. 숫자를 더하는 기능
+6. 결과를 출력하는 기능
+
+
+초기 구현 후 리팩토링 할 목록
+1. 문자열을 구분자를 기준으로 분리하는 기능 -> 기능들을 더 메소드 단위로 나누기
+
+
+예외처리
+1. 잘못된 입력

build.gradle

@@ -18,8 +18,12 @@ repositories {
 
 dependencies {
     implementation 'com.github.woowacourse-projects:mission-utils:1.2.0'
+    testImplementation 'org.mockito:mockito-core:4.11.0'
+    testImplementation 'org.mockito:mockito-inline:4.11.0'
+
 }
 
+
 test {
     useJUnitPlatform()
 }

settings.gradle

@@ -1,4 +1,4 @@
 plugins {
     id 'org.gradle.toolchains.foojay-resolver-convention' version '0.8.0'
 }
-rootProject.name = 'java-calculator'
+rootProject.name = 'java-menu'

src/main/java/menu/Application.java

@@ -0,0 +1,15 @@
+package menu;
+
+import menu.controller.RecommendationController;
+import menu.view.InputView;
+import menu.view.OutputView;
+
+public class Application {
+    public static void main(String[] args) {
+        InputView inputView = new InputView();
+        OutputView outputView = new OutputView();
+        RecommendationController recommendationController = new RecommendationController(inputView, outputView);
+
+        recommendationController.run();
+    }
+}

src/main/java/menu/controller/RecommendationController.java

@@ -0,0 +1,70 @@
+package menu.controller;
+
+import java.util.ArrayList;
+import java.util.List;
+import menu.domain.Categories;
+import menu.domain.Coach;
+import menu.domain.Coachs;
+import menu.domain.InedibleMenu;
+import menu.domain.RecommendMenu;
+import menu.domain.Recommendation;
+import menu.service.RecommendationService;
+import menu.view.InputView;
+import menu.view.OutputView;
+
+public class RecommendationController {
+    private final InputView inputView;
+    private final OutputView outputView;
+    private RecommendationService recommendationService;
+    private Recommendation recommendation;
+
+    public RecommendationController(InputView inputView,
+                                    OutputView outputView) {
+        this.inputView = inputView;
+        this.outputView = outputView;
+    }
+
+    public void run() {
+        outputView.printStart();
+        Coachs coachs = createCoachs();
+        for (Coach coach : coachs.getCoachs()) {
+            createInedible(coach);
+        }
+        Categories categories = new Categories();
+        recommendation = new Recommendation(coachs, categories);
+        recommendationService = new RecommendationService(recommendation);
+        recommendationService.recommendationMenu();
+        outputView.printResult(recommendation.getCategories().getCategories(),
+                recommendation.getCoachs().getCoachs());
+    }
+
+    private void createCoach(String coach, List<Coach> coaches) {
+        InedibleMenu inedibleMenu = new InedibleMenu();
+        RecommendMenu recommendMenu = new RecommendMenu();
+        coaches.add(new Coach(coach, inedibleMenu, recommendMenu));
+    }
+
+    private Coachs createCoachs() {
+        try {
+            List<Coach> coaches = new ArrayList<>();
+            List<String> inputCoachs = inputView.readCoachs();
+            for (String coach : inputCoachs) {
+                createCoach(coach, coaches);
+            }
+            Coachs coachs = new Coachs(coaches);
+            return coachs;
+        } catch (IllegalArgumentException e) {
+            System.out.println(e.getMessage());
+            return createCoachs();
+        }
+    }
+
+    private void createInedible(Coach coach) {
+        try {
+            coach.getInedibleMenu().setEdibleMenu(inputView.readInedibles(coach.getName()));
+        } catch (IllegalArgumentException e) {
+            System.out.println(e.getMessage());
+            createInedible(coach);
+        }
+    }
+}

src/main/java/menu/domain/Categories.java

@@ -0,0 +1,37 @@
+package menu.domain;
+
+import java.util.ArrayList;
+import java.util.List;
+import menu.util.Exception;
+
+public class Categories {
+    private List<String> categories = new ArrayList<>();
+
+    public Categories() {
+    }
+
+    public void addCategory(String category) {
+        validateCategory(category);
+        categories.add(category);
+    }
+
+    public boolean isComplete() {
+        if (categories.size() == 5) {
+            return true;
+        }
+        return false;
+    }
+
+    public List<String> getCategories() {
+        return categories;
+    }
+
+    private void validateCategory(String category) {
+        long count = categories.stream()
+                .filter(c -> c.equals(category))
+                .count();
+        if (count >= 2) {
+            throw new IllegalArgumentException(Exception.ERROR + Exception.OVER_CATEGORY_AMOUNT);
+        }
+    }
+}

src/main/java/menu/domain/Coach.java

@@ -0,0 +1,38 @@
+package menu.domain;
+
+import menu.util.Exception;
+
+public class Coach {
+    private final String name;
+    private InedibleMenu inedibleMenu;
+    private RecommendMenu recommendMenu;
+
+    public Coach(String name, InedibleMenu inedibleMenu, RecommendMenu recommendMenu) {
+        validateNameLength(name);
+        this.name = name;
+        this.inedibleMenu = inedibleMenu;
+        this.recommendMenu = recommendMenu;
+    }
+
+    public void addRecommendMenu(String menu) {
+        recommendMenu.addRecommendMenu(menu);
+    }
+
+    public String getName() {
+        return name;
+    }
+
+    public RecommendMenu getRecommendMenu() {
+        return recommendMenu;
+    }
+
+    public InedibleMenu getInedibleMenu() {
+        return inedibleMenu;
+    }
+
+    private void validateNameLength(String name) {
+        if (name.length() < 2 || name.length() > 4) {
+            throw new IllegalArgumentException(Exception.ERROR + Exception.COACH_NAME_LENGTH);
+        }
+    }
+}

src/main/java/menu/domain/Coachs.java

@@ -0,0 +1,57 @@
+package menu.domain;
+
+import java.util.ArrayList;
+import java.util.List;
+import menu.util.Exception;
+
+public class Coachs {
+    private List<Coach> coachs;
+
+    public Coachs(List<Coach> coachs) {
+        validateCoachAmount(coachs);
+        this.coachs = coachs;
+    }
+
+    public void recommendMenuOneCycle(String category) {
+        for (Coach coach : coachs) {
+            recommendMenu(coach, category);
+        }
+    }
+
+    public List<String> getCoachNames() {
+        List<String> coachNames = new ArrayList<>();
+        for (Coach coach : coachs) {
+            coachNames.add(coach.getName());
+        }
+        return coachNames;
+    }
+
+    public List<Coach> getCoachs() {
+        return coachs;
+    }
+
+    private void recommendMenu(Coach coach, String category) {
+        try {
+            String menu = Menu.recommendationMenu(category);
+            validateMenuIsInedible(coach, menu);
+            coach.addRecommendMenu(menu);
+        } catch (IllegalArgumentException e) {
+            recommendMenu(coach, category);
+        }
+    }
+
+    private void validateMenuIsInedible(Coach coach, String menu) {
+        if (coach.getInedibleMenu().isEdibleMenu(menu)) {
+            throw new IllegalArgumentException(Exception.ERROR);
+        }
+    }
+
+    private void validateCoachAmount(List<Coach> coachs) {
+        if (coachs.size() < 2) {
+            throw new IllegalArgumentException(Exception.ERROR + Exception.COACH_AMOUNT_UNDER_RANGE);
+        }
+        if (coachs.size() > 5) {
+            throw new IllegalArgumentException(Exception.ERROR + Exception.COACH_AMOUNT_OVER_RANGE);
+        }
+    }
+}

src/main/java/menu/domain/InedibleMenu.java

@@ -0,0 +1,41 @@
+package menu.domain;
+
+import java.util.ArrayList;
+import java.util.List;
+import menu.util.Exception;
+
+public class InedibleMenu {
+    private List<String> menus = new ArrayList<>();
+
+    public InedibleMenu() {
+    }
+
+    public boolean isEdibleMenu(String menu) {
+        if (menus.contains(menu)) {
+            return true;
+        }
+        return false;
+    }
+
+    public void setEdibleMenu(List<String> menus) {
+        if (!(menus.size() == 1 && menus.get(0).equals(""))) {
+            validateMenuAmount(menus);
+            validateInedibleMenu(menus);
+        }
+        this.menus = menus;
+    }
+
+    private void validateMenuAmount(List<String> menus) {
+        if (menus.size() > 2) {
+            throw new IllegalArgumentException(Exception.ERROR + Exception.INEDIBLE_MENU_AMOUNT_OVER_RANGE);
+        }
+    }
+
+    private void validateInedibleMenu(List<String> menus) {
+        for (String menu : menus) {
+            if (!Menu.isInMenu(menu)) {
+                throw new IllegalArgumentException(Exception.ERROR + Exception.NOT_EXIST_MENU);
+            }
+        }
+    }
+}

src/main/java/menu/domain/Menu.java

@@ -0,0 +1,48 @@
+package menu.domain;
+
+import camp.nextstep.edu.missionutils.Randoms;
+import java.util.ArrayList;
+import java.util.List;
+
+public enum Menu {
+    일식(1, List.of("규동", "우동", "미소시루", "스시", "가츠동", "오니기리", "하이라이스", "라멘", "오코노미야끼")),
+    한식(2, List.of("김밥", "김치찌개", "쌈밥", "된장찌개", "비빔밥", "칼국수", "불고기", "떡볶이", "제육볶음")),
+    중식(3, List.of("깐풍기", "볶음면", "동파육", "짜장면", "짬뽕", "마파두부", "탕수육", "토마토 달걀볶음", "고추잡채")),
+    아시안(4, List.of("팟타이", "카오 팟", "나시고렝", "파인애플 볶음밥", "쌀국수", "똠얌꿍", "반미", "월남쌈", "분짜")),
+    양식(5, List.of("라자냐", "그라탱", "뇨끼", "끼슈", "프렌치 토스트", "바게트", "스파게티", "피자", "파니니"));
+
+    private int category;
+    private List<String> menus;
+
+    Menu(int category, List<String> menus) {
+        this.category = category;
+        this.menus = menus;
+    }
+
+    public static String recommendationMenu(String category) {
+        return Randoms.shuffle(Menu.valueOf(category).menus).get(0);
+    }
+
+    public static boolean isInMenu(String inputMenu) {
+        List<String> allMenu = new ArrayList<>();
+        for (Menu value : Menu.values()) {
+            for (String menu : value.menus) {
+                allMenu.add(menu);
+            }
+        }
+        if (allMenu.contains(inputMenu)) {
+            return true;
+        }
+        return false;
+    }
+
+    public static String randomCategory() {
+        int number = Randoms.pickNumberInRange(1, 5);
+        for (Menu value : Menu.values()) {
+            if (value.category == number) {
+                return value.name();
+            }
+        }
+        return null;
+    }
+}

src/main/java/menu/domain/RecommendMenu.java

@@ -0,0 +1,27 @@
+package menu.domain;
+
+import java.util.ArrayList;
+import java.util.List;
+import menu.util.Exception;
+
+public class RecommendMenu {
+    private List<String> menus = new ArrayList<>();
+
+    public RecommendMenu() {
+    }
+
+    public void addRecommendMenu(String menu) {
+        validateRecommendMenu(menu);
+        menus.add(menu);
+    }
+
+    public List<String> getMenus() {
+        return menus;
+    }
+
+    private void validateRecommendMenu(String menu) {
+        if (menus.contains(menu)) {
+            throw new IllegalArgumentException(Exception.ERROR + Exception.DUPLICATE_RECOMMEND_MENU);
+        }
+    }
+}