Skip to content

Do not force image replacement during product updates. #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
peterwilsoncc wants to merge 2 commits into
base: trunk
Choose a base branch
from
Draft

Do not force image replacement during product updates. #428

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05811f4
Do not force image replacement during product updates.
peterwilsoncc Dec 2, 2025
3154d09
Merge branch 'trunk' into fix/SQUARE-202-respect-image-override-setting
iamdharmesh Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion includes/Sync/Product_Import.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
*
* @param int limit
*/
$limit = (int) apply_filters( 'wc_square_import_api_limit', 100 );

Check failure on line 78 in includes/Sync/Product_Import.php

View workflow job for this annotation

GitHub Actions / test

WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound 

Hook names invoked by a theme/plugin should start with the theme/plugin prefix. Found: "wc_square_import_api_limit".

return max( 1, min( 1000, $limit ) );
}
Expand Down Expand Up @@ -482,7 +482,7 @@
$this->save_product_meta( $product_id, $data );

// save the image, if included
Product::update_image_from_square( $product_id, $data['image_id'], true );
Product::update_image_from_square( $product_id, $data['image_id'], false );

// save/update variations
if ( isset( $data['type'], $data['variations'] ) && 'variable' === $data['type'] && is_array( $data['variations'] ) ) {
Expand Down Expand Up @@ -580,7 +580,7 @@
* and keep existing name.
* @since 3.3.0
*/
$product_name = apply_filters( 'wc_square_update_product_set_name', $product_name, $catalog_object, $product );

Check failure on line 583 in includes/Sync/Product_Import.php

View workflow job for this annotation

GitHub Actions / test

WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound 

Hook names invoked by a theme/plugin should start with the theme/plugin prefix. Found: "wc_square_update_product_set_name".

/**
* Allow overriding product description during import from Square
Expand All @@ -595,7 +595,7 @@
* and keep existing description.
* @since 3.3.0
*/
$product_description = apply_filters( 'wc_square_update_product_set_description', $product_description, $catalog_object, $product );

Check failure on line 598 in includes/Sync/Product_Import.php

View workflow job for this annotation

GitHub Actions / test

WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound 

Hook names invoked by a theme/plugin should start with the theme/plugin prefix. Found: "wc_square_update_product_set_description".
}

$data = array(
Expand Down
Loading