Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: improved xcodebuild performance by blocking Apple domain #202

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

wojciech-kulik
Copy link
Owner

BREAKING CHANGE: please see :h xcodebuild.xcodebuild-offline to enable tool that improves build speed.

More details about this issue here (#201):
#201 (comment)

@wojciech-kulik
Copy link
Owner Author

@Almaz5200 would you like to try it before I merge it? I would like to make sure that it works as expected.

tools/xcodebuild_offline Outdated Show resolved Hide resolved
@Almaz5200
Copy link
Contributor

@wojciech-kulik thank you for the invite! I've tried it and it works, and gives me an improvement consistent with the tests we did previously. However I do have some security concerns about this feature. In this current version any other program can just do ~/.local/share/nvim/lazy/xcodebuild.nvim/tools/xcodebuild_offline some_evil_stuff. And even if you remove sudo from line 29, wouldn't it be possible to modify this file in any malicious way from outside, do whatever you want and change it back?

Also for some reason visudo command makes my tmux crash, I only was able to run it from a plain terminal session

BREAKING CHANGE: (optional) please see `:h
xcodebuild.xcodebuild-offline` to enable tool that improves build speed.

More details about this issue here (#201):
#201 (comment)
@wojciech-kulik
Copy link
Owner Author

@Almaz5200 I finished :). You can check the code & docs one more time 🙏

@Almaz5200
Copy link
Contributor

Almaz5200 commented Oct 20, 2024

Looks great to me!
I thought in might be possible to inject something in the xcodebuild so that it expands to something like xcodebuild "-help"; some_bad_things "", but I was not able to do so, it seems "" escapes everything well.

So everything looks safe now, and the wiki describes the seriousness of it appropriately :D
Thank you for such a quick collaboration! 🍻 :)

@wojciech-kulik wojciech-kulik merged commit b9ad9d2 into main Oct 20, 2024
6 checks passed
@wojciech-kulik wojciech-kulik deleted the feature/issue-201 branch October 20, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants