Fix table of contents intersection observer #3656
Open
+353
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
size-limit report 📦
|
1 task
- Correctly highlights “Overview” for content preceding first subheading (this was incorrectly being attributed *to* the first subheading in our updated code in the previous commit - Correctly selects elements for observation to avoid excluding elements that include an `id`’d element which isn’t a heading (e.g. tabs) - Fixes returning headings from `getHeadingElement()` that aren’t in the ToC, a bug introduced in the previous commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue with Starlight’s intersection observer used for updating table of contents state, which we discovered while reviewing #3382 during Talking & Doc’ing today.
We found multiple issues:
<div>breaking an assumption in the table of contents logic..contentto.sl-markdown-content, but forgot to rename the same in a query selector here.This caused some subtle issues that were not super obvious, but we noticed them while digging deeper.