Skip to content

Conversation

@florian-lefebvre
Copy link
Member

Changes

  • Instead of mutating the provider name, we keep the mapping from the provider object to an ID inside the font resolver

Testing

Updated

Docs

N/A, internal refactor

@florian-lefebvre florian-lefebvre self-assigned this Jan 13, 2026
@changeset-bot
Copy link

changeset-bot bot commented Jan 13, 2026

⚠️ No Changeset found

Latest commit: 4099435

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 13, 2026
@florian-lefebvre florian-lefebvre marked this pull request as ready for review January 13, 2026 15:45
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 13, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing refactor/fonts-do-not-mutate-provider-name (4099435) with main (245a7d4)1

Summary

✅ 9 untouched benchmarks

Footnotes

  1. No successful run was found on main (8068bad) during the generation of this report, so 245a7d4 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants