fix(react): Prevent font copying when stopping dev server with q+enter #15178
+63
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dev server shutdown and add a test case to verify this behavior.
… files when stopping the dev server with the experimental Fonts API.
🦋 Changeset detectedLatest commit: 8cbbcbb The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
|
Member
|
The test is failing, can you look into that? |
…improve `ENOENT` test assertion.
Member
|
Ping me when tests pass and I'll be happy to review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dev server incorrectly creating dist folder and copying fonts when using q+enter to quit.
Changes
isBuildcheck inbuildEnd()hook to prevent font copying during dev server shutdownastro build, not when stopping dev server with q+enterfix-dev-quit-fonts-dist-creation.mdTesting
Docs
No docs changes needed. This fixes incorrect behavior in dev mode. User-facing behavior remains the same.