fix(sitemap): handle undefined _routes in server mode #15170
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using output: 'server', the astro:routes:resolved hook may not fire before astro:build:done, leaving _routes undefined. This causes a 'Cannot read properties of undefined (reading reduce)' error. This fix adds a nullish coalescing operator to default to an empty array, preventing the crash while maintaining existing behavior.
🦋 Changeset detectedLatest commit: 063f229 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
Member
florian-lefebvre
left a comment
florian-lefebvre
left a comment
There was a problem hiding this comment.
The hooks should always fire, can you open a new issue with a minimal reproduction first?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a crash when using
@astrojs/sitemapwithoutput: 'server'mode that results in:Problem
When using
output: 'server'in Astro config, theastro:routes:resolvedhook may not fire beforeastro:build:done, leaving the_routesvariable undefined. When the sitemap integration tries to call_routes.reduce(), it crashes.Solution
Added a nullish coalescing operator to default
_routesto an empty array:This prevents the crash while maintaining existing behavior - if routes aren't available, the sitemap will simply not include route-based URLs (falling back to pages and customPages).
Testing
Tested with an Astro project using:
output: 'server'@astrojs/nodeadapterRelated Issues
Changeset
Included a patch changeset for
@astrojs/sitemap.