feat(sitemap): add separator option #11898
Open
+17
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f6843bf The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
this allow you to output sitemap files without dashes
Hacksore
force-pushed
the
feat/sitemap-filename
branch
from
14e3f3a
to
81afe61
Compare
Hacksore
force-pushed
the
feat/sitemap-filename
branch
from
81afe61
to
eb935e2
Compare
Hacksore
changed the title
Hacksore
commented
Sep 2, 2024
| @@ -64,6 +66,6 @@ export async function writeSitemap( | |||
| }); | |||
|
|
|||
| let src = Readable.from(sourceData); | |||
| const indexPath = resolve(destinationDir, `./sitemap-index.xml`); | |||
There was a problem hiding this comment.
not sure if we want to change this at all but if we set separator: "" then it'd be sitemapindex.xml.
This makes sense for sitemap-0.xml => sitemap0.xml but not sure about the index?
happy to change anything if we need to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion/RFC withastro/roadmap/discussions/940