1.20.5 port tm #217
Merged
1.20.5 port tm #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noaaan
reviewed
Apr 20, 2024
src/main/java/io/wispforest/owo/serialization/util/EndecRecipeSerializer.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
I assume this change comes from the change to use the ItemStack Codec in the RecipeManagerMixin? I noticed the else still has a field for getting "item" on line 42
There was a problem hiding this comment.
yep, i changed it because vanilla uses the main ItemStack codec now and this recipe started logging errors
Co-authored-by: Noaaan <[email protected]>
gliscowo
reviewed
Apr 23, 2024
…'RegistryOps' and endec's 'REGISTRIES' attribute is still missing
gliscowo
approved these changes
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:poggus: