Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak in the creation of Vad object #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

manipopopo
Copy link

The Vad objects are not freed due to the additional reference counts introduced by Py_BuildValue.

The memory usage of the following program is increasing steadily:

import webrtcvad

for _ in range(100000000):
    vad = webrtcvad.Vad(3)

@MLrookie
Copy link

MLrookie commented Mar 3, 2022

it seems that the memory leak problem still exist in the version2.0.10.

@daanzu
Copy link

daanzu commented Sep 5, 2024

FYI, I have implemented this change in my fork at https://github.com/daanzu/py-webrtcvad-wheels .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants