Bugs/564 fix maven raml builder plugin #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be referenced in annotation. The following are supported : - direct field access - access to field declared in an inner class or interface The following are not supported - access to field declared in another class, even if in the same package - access to a class defined from an expression (which can't happen, but is nevertheless considered as valid by javaparser)
…/564-fix-maven-raml-builder-plugin
|
Looks good to me ! @barjo is it ok for you ? |
|
thanks, merged ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #564 by allowing elements from inner classes to be referenced in annotation.
The following are supported :
The following are not supported
Notice using fields from other compilation units would be way harder, as they are not loaded by javaparser