feat: refactor CI tests - WPB-11406 #1707
Draft
+905
−731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netbe
commented
Sep 11, 2024
| @@ -676,8 +741,6 @@ class Build | |||
| result = "playground-#{normalized_branch_name}/#{suffix}" | |||
| when "Development" | |||
| result = "development/#{suffix}" | |||
| when "Internal" | |||
There was a problem hiding this comment.
these are unused build flavors
netbe
commented
Sep 13, 2024
| @@ -268,7 +323,7 @@ platform :ios do | |||
| end | |||
|
|
|||
| def generate_build_number | |||
| build_number = `curl -H "Accept: text/plain" -X POST -d '' "https://incrementator.appspot.com/api/v1/code/ORUHILeMbXB4D5Z5conFzYoYpQPjVnyUA4pu56X2MHVJSFxM/increment"` | |||
| build_number = `curl -H "Accept: text/plain" -X POST -d '' "https://incrementator.appspot.com/api/v1/code/iqZCQLhyVYKxWVzecuQHXBbhfJJJdtoxUXvtMzn99MoFlJIW/increment"` | |||
Test Results59 tests 57 ✅ 19s ⏱️ Results for commit 1a03543. ♻️ This comment has been updated with latest results. |
echoes-hq
bot
added
the
echoes: throughput/ci-maintenance
netbe
force-pushed
the
feat/refactor-ci-tests
branch
from
8597c93
to
1797a97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR allows to test all related frameworks when touching a framework on a PR. Previously it was not running tests of frameworks having the dependency.
It also moves the develop tests that are run when a PR is merged to be run nightly at 21:00.
TODO
Testing
Running PR as a test
Checklist
[WPB-XXX].